mbutrovich commented on code in PR #1192: URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1901070776
########## native/core/Cargo.toml: ########## @@ -52,6 +52,8 @@ serde = { version = "1", features = ["derive"] } lazy_static = "1.4.0" prost = "0.12.1" jni = "0.21" +snap = "1.1" +lz4_flex = { version = "0.11.3", default-features = false } Review Comment: This is a somewhat confusingly named feature flag. Can we leave a comment here that we're enabling unsafe encode and decode for performance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org