mbutrovich commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1901247700
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -1650,18 +1719,44 @@ mod test {
#[test]
#[cfg_attr(miri, ignore)] // miri can't call foreign function
`ZSTD_createCCtx`
- fn write_ipc_zstd() {
+ fn roundtrip_ipc_zstd() {
let batch = create_batch(8192);
let mut output = vec![];
let mut cursor = Cursor::new(&mut output);
- write_ipc_compressed(
+ let length = write_ipc_compressed(
&batch,
&mut cursor,
&CompressionCodec::Zstd(1),
Review Comment:
Could we modify this test so instead of being named `round_trip_zstd` it
iterates through all the compression schemes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
