mbutrovich commented on code in PR #1192:
URL: https://github.com/apache/datafusion-comet/pull/1192#discussion_r1901249341
##########
native/core/src/execution/shuffle/shuffle_writer.rs:
##########
@@ -1570,13 +1588,41 @@ pub fn write_ipc_compressed<W: Write + Seek>(
// write ipc_length placeholder
output.write_all(&[0u8; 8])?;
Review Comment:
I know this isn't new code on this PR, but it jumped out at me: can this be
a seek_relative? For example:
```
// Seek past placeholder for ipc_length.
output.seek_relative(8)?;
```
I tried it and it seemed to work but I'm not sure I ran all of the necessary
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
