aIbrahiim commented on code in PR #37725: URL: https://github.com/apache/beam/pull/37725#discussion_r2886735484
########## sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_test.py: ########## @@ -58,6 +61,8 @@ model_name: str = "text-embedding-005" +@skip_if_vertex_ai_disabled [email protected]_ai_postcommit Review Comment: ahh the decorator runs at collection time and only checks if the sdk is there at all so the test file’s imports run when the test runs and are for the specific stuff that test needs soo the skip is one generic check as the test file does its own imports for the APIs it uses -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
