tvalentyn commented on code in PR #37725: URL: https://github.com/apache/beam/pull/37725#discussion_r2886708569
########## sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_test.py: ########## @@ -58,6 +61,8 @@ model_name: str = "text-embedding-005" +@skip_if_vertex_ai_disabled [email protected]_ai_postcommit Review Comment: ok, we typically name dataflow tests as _it_test (integration test) in the file name, in this case I'd suggest we also rename this file to vertex_ai_it_test.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
