aIbrahiim commented on code in PR #37725:
URL: https://github.com/apache/beam/pull/37725#discussion_r2886703126
##########
sdks/python/tox.ini:
##########
@@ -515,13 +515,14 @@ commands =
[testenv:py{310,311}-transformers-{428,447,448,latest}]
deps =
# Environment dependencies are defined in the `setenv` section and installed
in the `commands` section.
-extras = test,gcp,ml_test
+pip_pre = False
+extras = test
setenv =
COMMON_DEPS = tensorflow==2.12.0 protobuf==4.25.5 pip==25.0.1
# sentence-transformers 2.2.2 is the latest version that supports
transformers 4.28.x
428: DEPS = sentence-transformers==2.2.2 'transformers>=4.28.0,<4.29.0'
'torch>=1.9.0,<1.14.0'
447: DEPS = 'transformers>=4.47.0,<4.48.0' 'torch>=1.9.0,<1.14.0'
- 455: DEPS = 'transformers>=4.55.0,<4.56.0' 'torch>=2.0.0,<2.1.0'
+ 448: DEPS = 'transformers>=4.48.0,<4.49.0' 'torch>=1.9.0,<1.14.0'
Review Comment:
Ahh alright got it, and the 448 env was failing because the config had 455:
DEPS for 4.55.x but the env name was 448 so that the env had no DEPS so i added
448 with 4.48.x only to get the task running not because we need to test 4.48.x
so now i got it and will switch this to 455 (env name + DEPS) and use 4.55.x so
we test the same version we use in the containers like in gpu_image_requirements
##########
sdks/python/tox.ini:
##########
@@ -515,13 +515,14 @@ commands =
[testenv:py{310,311}-transformers-{428,447,448,latest}]
deps =
# Environment dependencies are defined in the `setenv` section and installed
in the `commands` section.
-extras = test,gcp,ml_test
+pip_pre = False
+extras = test
setenv =
COMMON_DEPS = tensorflow==2.12.0 protobuf==4.25.5 pip==25.0.1
# sentence-transformers 2.2.2 is the latest version that supports
transformers 4.28.x
428: DEPS = sentence-transformers==2.2.2 'transformers>=4.28.0,<4.29.0'
'torch>=1.9.0,<1.14.0'
447: DEPS = 'transformers>=4.47.0,<4.48.0' 'torch>=1.9.0,<1.14.0'
- 455: DEPS = 'transformers>=4.55.0,<4.56.0' 'torch>=2.0.0,<2.1.0'
+ 448: DEPS = 'transformers>=4.48.0,<4.49.0' 'torch>=1.9.0,<1.14.0'
Review Comment:
Ahh alright got it, and the 448 env was failing because the config had 455:
DEPS for 4.55.x but the env name was 448 so that the env had no DEPS so i added
448 with 4.48.x only to get the task running not because we need to test 4.48.x
so now i got it and will switch this to 455 (env name + DEPS) and use 4.55.x so
we test the same version we use in the containers like in gpu_image_requirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
