tvalentyn commented on code in PR #37725: URL: https://github.com/apache/beam/pull/37725#discussion_r2886723401
########## sdks/python/apache_beam/ml/transforms/embeddings/vertex_ai_test.py: ########## @@ -58,6 +61,8 @@ model_name: str = "text-embedding-005" +@skip_if_vertex_ai_disabled [email protected]_ai_postcommit Review Comment: for example, in this particular case: we already import ``` try: from vertexai.vision_models import Image from vertexai.vision_models import Video from vertexai.vision_models import VideoSegmentConfig ``` i would then ask - why do we also need to try to import vertexai -- doesn't a successful import of ` from vertexai.vision_models import Image` already imply that vertexai is importable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
