tvalentyn commented on code in PR #37725:
URL: https://github.com/apache/beam/pull/37725#discussion_r2886735682
##########
sdks/python/apache_beam/ml/rag/embeddings/vertex_ai_test.py:
##########
@@ -58,6 +61,7 @@ def chunk_approximately_equals(expected, actual):
all(isinstance(x, float) for x in actual.embedding.dense_embedding))
[email protected]_ai_postcommit
@unittest.skipIf(
not VERTEX_AI_AVAILABLE, "Vertex AI dependencies not available")
Review Comment:
as mentioned elsewhere, let's standartize on these checks and not test
twice. I would probably stick with trying to import vertex ai as this is a
common pattern in many other tests, and for many other dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
