Attention is currently required from: Timur Davydov.

pespin has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )

Change subject: transceiver: split control command handling from socket I/O
......................................................................


Patch Set 4:

(2 comments)

File Transceiver52M/Transceiver.h:

https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/d5639cae_a7a1d474?usp=email
 :
PS3, Line 220:  int ctrl_cmd_handle(int chan, const char *buffer, char 
*response, size_t response_size);
> Fixed indentation.
Done


File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/9cda1e77_3d495c9f?usp=email
 :
PS4, Line 913:     snprintf(response, response_size, "RSP POWEROFF 0");
This change to snprintf is welcome but it is definetly a different patch.



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: Timur Davydov <[email protected]>
Gerrit-Comment-Date: Tue, 17 Mar 2026 08:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: Timur Davydov <[email protected]>

Reply via email to