Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 3: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/1868fef0_a0478afb?usp=email : PS3, Line 1026: return -EINVAL; > The logic is preserved here. […] My point is that I don't see why do you decided to move the "return EINVAL here instead of 0 and decide to convert EINVAl to o 0 in other function" logic. I see no good reason to do that in this patch. If you consider that this path should return an error instead of 0 (which may be correct) then please submit a different patch changing this. It seems the diferentiation for this path returning non-error was made in 76ff96e21079db2cd7123ff9ca33fa7d2fb0cb01 (by me) but there's no real description on why was that, and I think we should indeed fail if timeslot reading fails. So please, if you want to change the logic, submit a patch before or after this one. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2026 11:44:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
