Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 3: (4 comments) File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/c2c6ca89_074e5eab?usp=email : PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); wrong indentation related to all other lines in this file. File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/df8a55eb_6c0bdd23?usp=email : PS3, Line 831: static bool match_cmd(const char *buf, This can be done in a previous separate commit. https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/479c73f3_0fcece3b?usp=email : PS3, Line 1026: return -EINVAL; This logic change looks unrelated to this patch, please split into several patches. https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/75d6bac3_be8879a7?usp=email : PS3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ This is a logic change, please split into separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:01:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
