Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 4: (4 comments) File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/1c5ee6e8_752d670d?usp=email : PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); > It's fine if CI fails in this file, we wan overwrite it manually. Fixed indentation. File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/c601bc4a_e9677bee?usp=email : PS3, Line 831: static bool match_cmd(const char *buf, > This can be done in a previous separate commit. I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42420 https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/ee89e3f1_ada61c16?usp=email : PS3, Line 1026: return -EINVAL; > My point is that I don't see why do you decided to move the "return EINVAL > here instead of 0 and dec […] I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42421 https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/34518f1f_307609fb?usp=email : PS3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > The logic is preserved here. […] I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42421 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2026 17:05:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: Timur Davydov <[email protected]>
