Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 3: (2 comments) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/c3610f30_6b28b2bd?usp=email : PS3, Line 1026: return -EINVAL; > This logic change looks unrelated to this patch, please split into several > patches. The logic is preserved here. The different return code is only used to distinguish this case from a normal `0` return value after the function was split. Previously this condition was handled in the same function, so there was no need to differentiate it. https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/43f6339a_bbd15495?usp=email : PS3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > This is a logic change, please split into separate patch. The logic is preserved here. Previously, when the timeslot was out of range, the function returned 0. After splitting the function, ctrl_cmd_handle() returns -EINVAL for that case, and ctrl_sock_handle_rx() converts it back to 0 to keep the original behavior. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2026 11:34:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
