>>>>> On Tue, 30 Sep 2008, Petteri Räty wrote: >>> dodoc ${DOCS} || die "dodoc failed" >> This seems alright fine to me
> It's not. If you want to have default DOCS then you should loop > through the items and check with [[ -e ]] before trying to install > them. I'm not convinced that this is a good idea. Then you won't catch cases where upstream removes or renames files. Besides, dodoc already checks for -e by itself (and emits a warning if the file does not exist). So, maybe just do a 'dodoc "${DOCS}"' and omit the die? Then it won't fail but the warning message would be preserved. Ulrich