>>>>> On Sun, 5 Oct 2008, Robert Buchholz wrote:

>> So if the ebuild includes non-existing files in DOCS, then why would
>> you want to suppress the warnings?

> I don't. My point was that the default action on an empty DOCS
> variable is to "dodoc AUTHORS ChangeLog NEWS README", and this
> should not emit warnings, because it is merely a heuristic.

> To be clearer:
>          else
> -                # No die here because we don't know if any of these exist
> -                dodoc AUTHORS ChangeLog NEWS README
> +                for x in AUTHORS ChangeLog NEWS README; do
> +                        if [ -e ${x} ]; then
> +                                dodoc ${x} || die "dodoc ${x} failed"
> +                        fi
> +                done
>          fi

I agree. You (and Petteri) are absolutely right.

Ulrich

Reply via email to