Hi Dave: Without deep analysis I have no idea what parts are D3. If this whole file > is based on D3 then in my opinion this whole source file needs to be BSD-3 > clause licensed. > > I would change my VOTE to +1 if there is a good explanation. >
The whole file is based on the tree layout of D3. But we modified the code a lot so the layout algorithm can be integrated into our architecture. Dave Fisher <dave2w...@comcast.net> 于2018年6月1日周五 上午1:07写道： > Hi - > > I’m VOTING +0. > > (1) I am rather confused by this D3 license. For example: > > src/chart/tree/layoutHelper.js > /* > * Licensed to the Apache Software Foundation (ASF) under one > * or more contributor license agreements. See the NOTICE file > * distributed with this work for additional information > * regarding copyright ownership. The ASF licenses this file > * to you under the Apache License, Version 2.0 (the > * "License"); you may not use this file except in compliance > * with the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, > * software distributed under the License is distributed on an > * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > * KIND, either express or implied. See the License for the > * specific language governing permissions and limitations > * under the License. > */ > > /* > * The tree layout implementation references to d3.js > * (https://github.com/d3/d3-hierarchy). The use of the source > * code of this file is also subject to the terms and consitions > * of its license (BSD-3Clause, see <echarts/src/licenses/LICENSE-d3>). > */ > > /** > * @file The layout algorithm of node-link tree diagrams. Here we using > Reingold-Tilford algorithm to drawing > * the tree. > * @see https://github.com/d3/d3-hierarchy > */ > > import * as layout from '../../util/layout'; > ... > > Without deep analysis I have no idea what parts are D3. If this whole file > is based on D3 then in my opinion this whole source file needs to be BSD-3 > clause licensed. > > I would change my VOTE to +1 if there is a good explanation. > > (2) I think that licenses/LICENSE-zrender is covered by the SGA. If this > is correct then this file needs to be removed. > > (3) KEYS should not be included in the release package. > > (4) RELEASE-NOTE.txt should be part of the release package. > > Regards, > Dave > > On May 30, 2018, at 11:28 PM, Justin Mclean <jus...@classsoftware.com> > wrote: > > Hi, > > sankeyLayout.js is mainly an improved implementation of the original d3 > sankey layout algorithm. We will add sankeyLayout.js to the list of files > embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if > needed. > > > Seems like it should be to me. Any modification of code are in general > under the license of the original unless they are extensive. All licenses > of any bundled software need to be mentioned in LICENSE. > > And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But > the implementation and code are different. In this case, should we still > add the LICENSE of simpleheat? > > > IMO (but IANAL) “inspired by” means to me that they have copied at least > some of it. If at some future time the license isn’t actually needed in > LICENSE that’s OK as it just a documentation issue, but if it was required > and not included that would be a licensing error. If that doesn’t convince > you may be best to ask on legal discuss for an answer. > > (But either way it still only a minor issue as all the licenses are > permissive and my +1 still stands.) > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > > -- Yi Shen Senior Developer Baidu, Inc.
