My vote is +1 binding. But when I check the source file with github repo[1]. I found there are > some directories are missed. > I guess we can skip the benchmark, tests, but I'm not sure for the theme > directory. Can you explain it? > We need to make sure we can build the full function binary from the source > release. > BTW, it looks there lots of github links in the README.md[2] need to be > updated. > And echarts need to move the website to echarts.incubator.apache.org from > baidu.
Willem, thanks for pointing out the issues. Wenli Zhang has made a request for the apache website server. We will move the English website to echarts.incubator.apache.org after that. Not sure if it's ok but we prefer the Chinese website keep the url https://www.echartsjs.com/ , which is used currently The theme folder will not be included when building the distribution. It' more like resources which can be used externally, like geojson data in the map folder on the GitHub. Willem Jiang <willem.ji...@gmail.com> 于2018年5月31日周四 上午10:19写道： > Hi > > I just tried to build the source according to the instruction in the mail, > it works. > But when I check the source file with github repo[1]. I found there are > some directories are missed. > I guess we can skip the benchmark, tests, but I'm not sure for the theme > directory. Can you explain it? > We need to make sure we can build the full function binary from the source > release. > > BTW, it looks there lots of github links in the README.md[2] need to be > updated. > And echarts need to move the website to echarts.incubator.apache.org from > baidu. > > > [1] https://github.com/apache/incubator-echarts > [2]https://github.com/apache/incubator-echarts/blob/master/README.md > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Tue, May 29, 2018 at 5:09 PM, SHUANG SU <sushuang0...@gmail.com> wrote: > > > After removing some generated files and bin files from 4.1.0.rc3, only > > source code kept in the artifact. > > I am pleased to be calling this vote for the release of Apache ECharts > > 4.1.0.rc4. > > > > > > Apache ECharts community has voted and approved the release. > > > > Vote thread: > > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > > > Results thread: > > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > > > The release candidate to be voted over is available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > > > The release candidate is signed with a GPG key available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > The Git commit for this release is: > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > > git;a=commit;h=02842e2 > > > > The Release Note is available in: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc4/RELEASE_NOTE.txt > > > > Some shell commands for validating the release: > > > > ```shell > > # Download the release: > > curl > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc4/apache-echarts-4.1.0.rc4-incubating-src.zip > > -o apache-echarts-4.1.0.rc4-incubating-src.zip > > unzip apache-echarts-4.1.0.rc4-incubating-src.zip -d > > apache-echarts-4.1.0.rc4-incubating-src > /dev/null > > > > # Rebuild the project (Node.js environment is required): > > cd "apache-echarts-4.1.0.rc4-incubating-src" && npm install && cd .. > > node "apache-echarts-4.1.0.rc4-incubating-src/build/build.js" --release > > # (See help: `node "apache-echarts-4.1.0.rc4- > > incubating-src/build/build.js" > > --help`) > > ``` > > > > > > Please vote on releasing this package as: > > Apache ECharts 4.1.0.rc4 > > > > This vote will be open until "2018-06-01T10:02:35.437Z". > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > ------------------------------ > > Su Shuang (100pah) > > ------------------------------ > > > -- Yi Shen Senior Developer Baidu, Inc.
