Thanks Justin!
> LICENSE is probably missing: > - MIT licensed sankey layout [1] in [2][3] > - 2 clause BSD Heatmap layer [4] in [5] I will try to explain these two concerns about LICENSE. sankeyLayout.js is mainly an improved implementation of the original d3 sankey layout algorithm. We will add sankeyLayout.js to the list of files embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if needed. And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But the implementation and code are different. In this case, should we still add the LICENSE of simpleheat? Justin Mclean <jus...@classsoftware.com> 于2018年5月31日周四 上午9:04写道： > Hi, > > +1 binding > > I checked: > - incubating in name > - signatures and hashes good > - DISCLAIMER exists > - LICENSE is probably missing a few things (see below) > - NOTICE is good > - No binary files in release > - All source files have ASF headers > > LICENSE is probably missing: > - MIT licensed sankey layout [1] in [2][3] > - 2 clause BSD Heatmap layer [4] in [5] > > Some other very minor things: > - no need for KEYS file in the release > - looks like package.json could do with an update re URL and authors > - missing README or like on how to “compile” / use > > Thanks, > Justin > > 1. https://github.com/ricklupton/sankey-layout > 2. src/chart/sankey/sankeyLayout.js > 3. src/chart/themeRiver/themeRiverLayout.js > 4. https://github.com/mourner/simpleheat > 5. src/chart/heatmap/HeatmapLayer.js > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Senior Developer Baidu, Inc.
