Hi, > sankeyLayout.js is mainly an improved implementation of the original d3 > sankey layout algorithm. We will add sankeyLayout.js to the list of files > embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if > needed.
Seems like it should be to me. Any modification of code are in general under the license of the original unless they are extensive. All licenses of any bundled software need to be mentioned in LICENSE. > And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But > the implementation and code are different. In this case, should we still > add the LICENSE of simpleheat? IMO (but IANAL) “inspired by” means to me that they have copied at least some of it. If at some future time the license isn’t actually needed in LICENSE that’s OK as it just a documentation issue, but if it was required and not included that would be a licensing error. If that doesn’t convince you may be best to ask on legal discuss for an answer. (But either way it still only a minor issue as all the licenses are permissive and my +1 still stands.) Thanks, Justin --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
