I took a look at the Emacs commit hook scripts and I didn't see anything
that looked unusual, although I'm also not familiar enough to say for
certain. I went ahead and created an additional patch for those scripts
along with some minor tweaks to refer to the correct CONTRIBUTE.org file
and to add a check for two spaces after sentences. I also added a new
regexp for the numeric value check and to construct the cookie regexp for
the main patch. Looking forward to feedback.

Thanks,

Derek



On Wed, Nov 5, 2025 at 12:15 PM Derek Chen-Becker <[email protected]>
wrote:

>
>
> On Wed, Nov 5, 2025 at 11:52 AM Ihor Radchenko <[email protected]>
> wrote:
>
>>
>> Not in Org repository, but we can borrow one from Emacs repo. Do you
>> want to prepare a patch for that? (I can do it myself, but want a second
>> pair of eyes to take a look what Emacs does and whether things will work
>> for Org as well)
>>
>
> Let me look at what Emacs is doing and add it as a patch along with these.
>
> I think that an additional defvar with regexp will be useful to have. I
>> do not like hard-coding regexps in the code.
>
>
> Sounds good, let me make that change.
>
> Cheers,
>
> Derek
>
>
> --
> +---------------------------------------------------------------+
> | Derek Chen-Becker                                             |
> | GPG Key available at https://keybase.io/dchenbecker and       |
> | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org |
> | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7  7F42 AFC5 AFEE 96E4 6ACC  |
> +---------------------------------------------------------------+
>
>

-- 
+---------------------------------------------------------------+
| Derek Chen-Becker                                             |
| GPG Key available at https://keybase.io/dchenbecker and       |
| https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org |
| Fngrprnt: EB8A 6480 F0A3 C8EB C1E7  7F42 AFC5 AFEE 96E4 6ACC  |
+---------------------------------------------------------------+

Attachment: 0003-lisp-org.el-Add-proper-support-for-numeric-prioritie.patch
Description: Binary data

Attachment: 0002-lisp-org.el-Remove-deprecated-show-command.patch
Description: Binary data

Attachment: 0001-git-hooks-Add-git-hook-scripts-along-with-instructio.patch
Description: Binary data

Reply via email to