On Sat, Nov 15, 2025 at 2:45 PM Ihor Radchenko <[email protected]> wrote:
> The hooks refer to CONTRIBUTE.org, so let's put a section in there, > linking to WORG website, just as the existing sections in CONTRIBUTE.org > do. > OK, I can update the section in CONTRIBUTE.org and add a separate patch for the WORK repo. > I guess the question is who is the target auditory for these hooks. > Should it be occasional contributors? Should it be regular contributors? > If the former, we should include the hooks as a part of make all. > If the latter, maybe not. > My humble opinion is to make it opt-in and give people instructions for installation via a `githook' target instead of making it automatic for everyone. I want these to be a useful tool for folks, but not necessarily a requirement, since we validate the commit message as part of patch review anyway (we can always mention them in reviews if we see problems with the message) > P.S. I tested the hooks a bit, and it looks like they have > false-positives when inserting long Urls - complain about "too long > word" and "too long line". > I can either disable those or we can try to tune them to better align with Org's rules for line length. Are you saying that they're too short, or that long URLs should be exempt from line length requirements? Cheers, Derek -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
