Still working through some testing and improvements on the main commit message, but I'm attaching the patch to remove the deprecated `show' parameter for `org-priority'.
Thanks, Derek On Sat, Oct 11, 2025 at 6:51 AM Ihor Radchenko <[email protected]> wrote: > Derek Chen-Becker <[email protected]> writes: > > > I think I have most of the patch fixed up based on the other feedback, > but > > I'm having some difficulty with customization. I think I have the > > customization correct, but I can't figure out how to test that validation > > operates on any values. I don't see anything in the current unit tests > for > > `org-property-separators' to reject bad values or otherwise validate > > values. Here's what I currently have for `org-priority-highest`: > > ... > > This does validate things if I use the customize interface, but is there > a > > way to do it programmatically so that I can unit test it? I found > > `customize-set-value' and `customize-set-variable' but neither of those > > seem like the right function. > > See how it is done in `setopt--set'. > > -- > Ihor Radchenko // yantar92, > Org mode maintainer, > Learn more about Org mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92> > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
From 76dacea15031f202a75757bae86e5d9b5aac8018 Mon Sep 17 00:00:00 2001 From: Derek Chen-Becker <[email protected]> Date: Tue, 29 Jul 2025 06:19:32 -0600 Subject: [PATCH] lisp/org.el: Remove deprecated show command * org.el (org-priority): Remove the deprecated show command now that we're several versions beyond when the deprecation was introduced. * etc/ORG-NEWS: Add an announcement for the removal of the `show' parameter. --- etc/ORG-NEWS | 6 ++++++ lisp/org.el | 6 +----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index e767bae00..a2d93a863 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -148,6 +148,12 @@ Previously, the whole contents of drawer, including blank lines at the beginning parsed as paragraph. Now, the blank lines at the beginning are stored in ~:pre-blank~ property, just as in other greater elements. +*** The deprecated =show= parameter to =org-priority= has been removed + +The =show= parameter for the =org-priority= function was deprecated in +Org 9.2 (released in 2017). Sufficient time has passed and it is being +removed as part of refactoring for numeric priorities. + ** New features # We list the most important features, and the features that may diff --git a/lisp/org.el b/lisp/org.el index 6b8d02b87..6c6a0058d 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -11321,7 +11321,7 @@ This regular expression matches these groups: (interactive) (org-priority 'down)) -(defun org-priority (&optional action show) +(defun org-priority (&optional action) "Change the priority of an item. When called interactively with a `\\[universal-argument]' prefix, @@ -11330,10 +11330,6 @@ show the priority in the minibuffer instead of changing it. When called programmatically, ACTION can be `set', `up', `down', or a character." (interactive "P") - (when show - ;; Deprecation warning inserted for Org 9.2; once enough time has - ;; passed the SHOW argument should be removed. - (warn "`org-priority' called with deprecated SHOW argument")) (if (equal action '(4)) (org-priority-show) (unless org-priority-enable-commands -- 2.43.0
