On Sun, Sep 28, 2025 at 10:12 AM Ihor Radchenko <[email protected]> wrote:
> > Fair. Still, I think highlighting that cookie is a string would be > helpful: `org-priority-valid-cookie-string-p' or so. > Agreed, that makes sense. I'll change the name. > The main drawback is that interactive functions will show up in M-x > completions and may confuse users. Emacs generally moves towards making > M-x list more specific, only listing the immediately useful commands in > current context (see the new `execute-extended-command-for-buffer'). So, > adding interactive functions that will not be useful is not a good idea > IMHO. > OK, that makes sense, I didn't realize it. I'll remove the `interactive' from all of the functions that don't actually need to be interactive. > > `org-property-separators'. Also see restricted-sexp customization type > described in 15.4.2 Composite Types section of Elisp manual. > Cool, thanks for the pointers. I'll take a look and see what I can do. > > There is no echoing back. What is done in first branch of the if is > `read-string' that (1) displays MSG; (2) reads user input. > The other branch (that you modified) (1) displays MSG; (2) reads user > input as character. We display a message to tell user what to > input. After your change, "Priority A-C, SPC to remove: " message will > not be shown. > Got it, thanks. > > Sure. I do not oppose this. Just wanted you to document this behavior in > the docstring explicitly. > Makes sense, I'll update the docstring. > What about making `org-priority-valid-value-p' check the range as well? > If an option to ignore the range is necessary, it can be activated by > passing an optional argument. > OK, I can make that change. > > /etc/ORG-NEWS > Thanks,I'll update that. Cheers, Derek -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
