On Sun, Nov 2, 2025 at 6:08 AM Ihor Radchenko <[email protected]> wrote:
> Please use double space between sentences in the commit message. > ... > Just `error' I think. `user-error' is used when the requested user > command cannot be performed. Here, it is just a function that is called > with invalid value. > ... > What about 'remove? > All fixed in the latest patch. Is there an existing pre-commit script hook that can be used to validate formatting of commit messages? I feel like I'm going to forget the double-space again at some point. Happy to add one that folks could (optionally) use. > Why not using `org-priority-valid-cookie-string-p'? > I actually started thinking about that, but the difference here is that the existing `org-priority-regexp' is for a cookie (including the square brackets, e.g. "[#...]") whereas this match is for the raw value. I was considering adding a new `defvar' for `org-priority-value-regexp' that I could use with a new `org-priority-valid-value-string-p' predicate, as well as constructing `org-priority-regexp', but that felt a little overly complicated. I guess I could also just format the value read from the user appropriately and then call `org-priority-valid-cookie-string-p'. I'm open to suggestions. `cl-flet' would lead to slightly shorter code here. > Thanks! I wasn't aware of `cl-flet' but I changed the code to use it and I like it better :) The latest patches are attached, but I'm happy to make changes for the regexp (or any other improvements) if you want. Cheers, Derek -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
0002-lisp-org.el-Add-proper-support-for-numeric-prioritie.patch
Description: Binary data
0001-lisp-org.el-Remove-deprecated-show-command.patch
Description: Binary data
