Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/229#issuecomment-115379759
Looking much better. I think the `std::map` use is acceptable - it's not
modified on the critical path and so there are no allocations which should be
fine. Searching in `std::map` should be fast, especially for such a small set
of strings. The initialization, though, shouldn't be cut and pasted so many
places. Maybe that should be done in `Log::init_fields` as it is part of the
field initialization.
My only other general comment is that sometimes `Milestone::diff` is used
and sometimes the value are directly subtracted. That's a minor quibble,
though. The real improvement there was from the millisecond computations which
look a lot cleaner now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
