Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33060322
--- Diff: proxy/http/HttpSM.cc ---
@@ -6662,48 +6668,61 @@ HttpSM::update_stats()
}
char client_ip[INET6_ADDRSTRLEN];
ats_ip_ntop(&t_state.client_info.addr, client_ip, sizeof(client_ip));
- Error("[%" PRId64 "] Slow Request: "
- "client_ip: %s:%u "
- "url: %s "
- "status: %d "
- "unique id: %s "
- "redirection_tries: %d "
- "bytes: %" PRId64 " "
- "fd: %d "
- "client state: %d "
- "server state: %d "
- "ua_begin: %.3f "
- "ua_first_read: %.3f "
- "ua_read_header_done: %.3f "
- "cache_open_read_begin: %.3f "
- "cache_open_read_end: %.3f "
- "dns_lookup_begin: %.3f "
- "dns_lookup_end: %.3f "
- "server_connect: %.3f "
- "server_first_read: %.3f "
- "server_read_header_done: %.3f "
- "server_close: %.3f "
- "ua_close: %.3f "
- "sm_finish: %.3f "
- "plugin_active: %.3f "
- "plugin_total: %.3f",
- sm_id, client_ip,
ats_ip_port_host_order(&t_state.client_info.addr), url_string, status,
unique_id_string,
- redirection_tries, client_response_body_bytes, fd,
t_state.client_info.state, t_state.server_info.state,
- milestone_difference(milestones.sm_start, milestones.ua_begin),
- milestone_difference(milestones.sm_start,
milestones.ua_first_read),
- milestone_difference(milestones.sm_start,
milestones.ua_read_header_done),
- milestone_difference(milestones.sm_start,
milestones.cache_open_read_begin),
- milestone_difference(milestones.sm_start,
milestones.cache_open_read_end),
- milestone_difference(milestones.sm_start,
milestones.dns_lookup_begin),
- milestone_difference(milestones.sm_start,
milestones.dns_lookup_end),
- milestone_difference(milestones.sm_start,
milestones.server_connect),
- milestone_difference(milestones.sm_start,
milestones.server_first_read),
- milestone_difference(milestones.sm_start,
milestones.server_read_header_done),
- milestone_difference(milestones.sm_start,
milestones.server_close),
- milestone_difference(milestones.sm_start, milestones.ua_close),
- milestone_difference(milestones.sm_start, milestones.sm_finish),
- milestone_difference(milestones.sm_start,
milestones.plugin_active),
- milestone_difference(milestones.sm_start,
milestones.plugin_total));
+ Error(
+ "[%" PRId64 "] Slow Request: "
+ "client_ip: %s:%u "
+ "url: %s "
+ "status: %d "
+ "unique id: %s "
+ "redirection_tries: %d "
+ "bytes: %" PRId64 " "
+ "fd: %d "
+ "client state: %d "
+ "server state: %d "
+ "ua_begin: %.3f "
+ "ua_first_read: %.3f "
+ "ua_read_header_done: %.3f "
+ "cache_open_read_begin: %.3f "
+ "cache_open_read_end: %.3f "
+ "dns_lookup_begin: %.3f "
+ "dns_lookup_end: %.3f "
+ "server_connect: %.3f "
+ "server_first_read: %.3f "
+ "server_read_header_done: %.3f "
+ "server_close: %.3f "
+ "ua_close: %.3f "
+ "sm_finish: %.3f "
+ "plugin_active: %.3f "
+ "plugin_total: %.3f",
+ sm_id, client_ip, ats_ip_port_host_order(&t_state.client_info.addr),
url_string, status, unique_id_string, redirection_tries,
+ client_response_body_bytes, fd, t_state.client_info.state,
t_state.server_info.state,
+
milestone_difference(milestones.ms_get(TransactionMilestones::SM_START),
milestones.ms_get(TransactionMilestones::UA_BEGIN)),
--- End diff --
Is this done enough to justify `TransactionMilestones::different(enum,
enum)` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
