Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/229#issuecomment-114571019
I think the use of `std::map` is problematic because of its secondary
effects, most importantly having to duplicate a string just to do a look up is
a serious flaw IMHO. You might look at using `ts::Buffer` or `ts::ConstBuffer`
as the key type instead. Then you can use a length based comparison functor for
the `std::map` comparator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
