Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33060489
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8856,75 +8856,100 @@ HttpTransact::update_size_and_time_stats(State *s,
ink_hrtime total_time, ink_hr
// update milestones stats
if (http_ua_begin_time_stat) {
- HTTP_SUM_TRANS_STAT(http_ua_begin_time_stat,
milestone_difference_msec(milestones.sm_start, milestones.ua_begin))
+ HTTP_SUM_TRANS_STAT(http_ua_begin_time_stat,
milestone_difference_msec(milestones.ms_get(TransactionMilestones::SM_START),
+
milestones.ms_get(TransactionMilestones::UA_BEGIN)))
--- End diff --
Here, at least, `milestone_difference_msec()` should take the enum values
and do the `ms_get` internally. That would look a lot cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
