Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33297453
--- Diff: proxy/logging/LogField.cc ---
@@ -132,6 +168,13 @@ LogField::LogField(const char *name, const char
*symbol, Type type, MarshalFunc
m_time_field = (strcmp(m_symbol, "cqts") == 0 || strcmp(m_symbol,
"cqth") == 0 || strcmp(m_symbol, "cqtq") == 0 ||
strcmp(m_symbol, "cqtn") == 0 || strcmp(m_symbol,
"cqtd") == 0 || strcmp(m_symbol, "cqtt") == 0);
+
+ if (m_milestone_map.empty()) {
--- End diff --
This should really be in a local function or method, since it's used
multiple times.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
