Yeah, if you want clang to catch that then you would need to add a redundant prototype near the top of the C file (not actually a bad idea). On Dec 12, 2013 5:12 PM, "Ethan Jackson" <et...@nicira.com> wrote:
> Annoying that clang didn't catch that . . . I suppose it's cause > 'mutex' doesn't exist where we define netflow_run()'s protoype and we > have to annotate in both places. > > At any rate. I'll make a netflow_run__() function which doesn't > require the mutex. > > On Thu, Dec 12, 2013 at 2:56 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Sun, Dec 08, 2013 at 06:45:13PM -0800, Ethan Jackson wrote: > >> In future patches upcall handler threads will need to update netflow. > >> > >> Signed-off-by: Ethan Jackson <et...@nicira.com> > > > > I think I see a deadlock. gen_netflow_rec() requires 'mutex', > > netflow_run() excludes it, but the former calls the latter. > > > > Maybe I said it already but netflow_flow_hash() could take a const > > argument. > > > > Acked-by: Ben Pfaff <b...@nicira.com> > > >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
