On Sun, Dec 08, 2013 at 06:45:12PM -0800, Ethan Jackson wrote: > The netflow code has its tentacles all over the ofproto-dpif module. > This is fine today, but in future facets, which correspond roughly to > netflow_flows, will be retired. In preparation, this patch hides as > much implementation detail as possible inside the netflow module. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
A nice cleanup, thanks. I think that the flow parameter to netflow_expire(), netflow_flow_clear(), and netflow_flow_update() could be const. netflow_flow_update() initializes nf_flow->created to stats->used, but the call to netflow_expire__() in the middle appears to zero it, and nothing later on appears to reset it again. The names pkt_delta and byte_delta, in netflow_expire__(), used to make sense, but now they're just counts. In netflow_run(), in a comment, s/possilbe/possible/. Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
