On Sun, Dec 08, 2013 at 06:45:13PM -0800, Ethan Jackson wrote:
> In future patches upcall handler threads will need to update netflow.
> 
> Signed-off-by: Ethan Jackson <et...@nicira.com>

I think I see a deadlock.  gen_netflow_rec() requires 'mutex',
netflow_run() excludes it, but the former calls the latter.

Maybe I said it already but netflow_flow_hash() could take a const
argument.

Acked-by: Ben Pfaff <b...@nicira.com>

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to