On Oct 18, 2011, at 10:22 AM, Ben Pfaff wrote: > I'd prefer to limit this just to ofproto providers, so that it should > be declared in ofproto-provider.h instead of ofproto.h.
Makes sense. > I'd make ofproto_port_set_state() take a "struct ofport *" directly. > The caller should already have it. Yes, I was just using the same convention as other functions in ofproto.h. Now that it moved to ofproto-provider.h, I changed it. > I'd make ofproto_port_set_state() become a no-op if the state didn't > really change. Good suggestion. I made the change. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
