On Mon, Oct 17, 2011 at 10:31:48PM -0700, Justin Pettit wrote:
> This will be used in an upcoming commit.

I'd prefer to limit this just to ofproto providers, so that it should
be declared in ofproto-provider.h instead of ofproto.h.

I'd make ofproto_port_set_state() take a "struct ofport *" directly.
The caller should already have it.

I'd make ofproto_port_set_state() become a no-op if the state didn't
really change.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to