On Oct 18, 2011, at 9:53 AM, Ben Pfaff wrote: Thanks, I cleaned up the whitespace issues, the sparse warnings, the OVS endian typedefs, and updated the copyright.
> and then we get some useful warnings from sparse (at least with the > patch to include/linux/types.h that I posted separately): > > ../lib/stp.c:718:26: warning: invalid assignment: |= > ../lib/stp.c:718:26: left side has type unsigned char > ../lib/stp.c:718:26: right side has type restricted __be16 > ../lib/stp.c:721:26: warning: invalid assignment: |= > ../lib/stp.c:721:26: left side has type unsigned char > ../lib/stp.c:721:26: right side has type restricted __be16 > ../lib/stp.c:779:49: warning: restricted __be16 degrades to integer > ../lib/stp.c:1007:42: warning: restricted __be16 degrades to integer > > I think I saw that you fixed those in the next commit though. Yes, I found them the old fashioned way without these fancy static analyzers. > I didn't really read most of this patch, assuming that it was pretty > much the same as what was in the tree before. Yes, other than a few minor cleanups to make it closer to our current conventions and make it build cleanly, it's essentially the same. I put the more interesting changes in the following patch to highlight them. Thanks for the review. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
