On Fri, Oct 21, 2011 at 04:20:43PM -0700, Justin Pettit wrote:
> On Oct 18, 2011, at 1:23 PM, Ben Pfaff wrote:
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index 025cc5b..065acf0 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
> @@ -967,6 +967,11 @@ set_stp(struct ofproto *ofproto_, const struct
> ofproto_stp_settings *s)
> {
> struct ofproto_dpif *ofproto = ofproto_dpif_cast(ofproto_);
>
> + /* Only revalidate flows if the configuration changed. */
> + if (!s != !ofproto->stp) {
> + ofproto->need_revalidate = true;
> + }
Do you need to revalidate on partial changes, e.g. an stp-port-num
change?
Otherwise all your responses and updates look OK to me.
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
