Hi, Also note that that comment you linked to also includes "Aside from Apache-licensed dependencies which supply NOTICE files of their own, it is uncommon for a dependency to require additions to NOTICE.”
In this case, you do have Apache-licensed dependencies that do supply a NOTICE file. Kind Regards, Justin > On 5 Apr 2024, at 12:58 pm, Justin Mclean <jus...@classsoftware.com> wrote: > > HI, > >> The ASF recommendation also clearly states: "Under normal circumstances, >> there is no need to modify NOTICE to mention a bundled dependency." > > If you read that document carefully, it states this: > - Under normal circumstances, there is no need to modify NOTICE to mention a > bundled dependency. > - If the dependency supplies a NOTICE file, its contents must be analyzed and > the relevant portions bubbled up into the top-level NOTICE file. > > These two things are not at odds with each other. In this case, you have > included ALv2 source code that contains a NOTICE file, so its content needs > to be added to your notice file. The normal circumstances mentioned above > apply if you are bundling something under MIT or a BSD license or if the > bundled Apache-licensed software that doesn’t have a NOTICE file. > > Kind Regards, > Justin
