+1 (binding) - Checked the signature and the checksum - Ran the example notebooks against 0.6.1rc1 <https://github.com/tabular-io/docker-spark-iceberg/pull/142> - Did some checks locally and looks all good!
Thanks Honah for running the release! Kind regards, Fokko Op do 4 apr 2024 om 17:56 schreef Honah J. <hon...@apache.org>: > Hi Justin, > > Thanks for reviewing the release. There were some discussions about the > NOTICE file in the 0.6.0 release: PR#410 > <https://github.com/apache/iceberg-python/pull/410> and PR#413 > <https://github.com/apache/iceberg-python/pull/413>. Here are the reasons > why the following projects have not been included in the NOTICE: > (quoted from the PR) > > - Avro: Since we don't bundle the code, but just took some part of it, > and want to attribute the author. > - Thrift/Hive: We don't bundle any code, but just take the > Python-compiled Thrift definitions. > > Does the above explanation address your concern? Please let me know if you > have any other questions. > > Best regards, > Honah > > On Thu, Apr 4, 2024 at 1:43 AM Justin Mclean <jus...@classsoftware.com> > wrote: > >> Hi, >> >> I took a look at this, and the NOTICE file doesn't include the required >> information from the included Apache projects NOTICE files [1] >> >> Kind Regards, >> Justin >> >> 1. https://infra.apache.org/licensing-howto.html#alv2-dep >> >
