Justin, We addressed these questions with regard to LICENSE and NOTICE files in the last release. This comment <https://github.com/apache/iceberg-python/pull/410#issuecomment-1939148398> explains it well, which is why the NOTICE changes were reverted.
The ASF recommendation <https://infra.apache.org/licensing-howto.html> also clearly states: "Under normal circumstances, there is no need to modify NOTICE to mention a bundled dependency." In this case, there is only one portion of the codebase that is in question, which is an attribution of a small section of code covered in the LICENSE file. -Dan On Thu, Apr 4, 2024 at 4:39 PM Hussein Awala <huss...@awala.fr> wrote: > +1 (non-binding) > > - Verified signatures, checksums, and license > - Tested creating and reading a non-partitioned table with the Glue catalog > > On Fri, Apr 5, 2024 at 12:44 AM Justin Mclean <jus...@classsoftware.com> > wrote: > >> HI, >> >> Thanks for that. I don't understand "we don't bundle the code, but just >> took some part of it”. Either the code is in the source release or not in >> the source release; if any part of it is in the source release, then it is >> bundled. The LICENSE and NOTICE files need to relate to what is included in >> the release artefact. Looking at both those PRs, it seems in both cases, >> you do bundle code, but I understand why you might not want to mention th >> autogenerated code. Either way, I think a little more is needed here to >> make the NOTICE file in line with ASF policy. >> >> Kind Regards, >> Justin > >
