20/04/2018 15:23, Arnon Warshavsky: > > > > Lots of "!= 0"'s - you might gather by now that I don't like them :-) > > > > No way. Would have never guessed that :) > Sure. When in Rome..
It is a matter of taste. I like the explicit "!= 0". At least, explicit NULL comparisons are recommended in the coding style: http://dpdk.org/doc/guides/contributing/coding_style.html#null-pointers For boolean return, it is OK to be implicit. But for error codes, I think it is better to be explicit. Again, matter of taste. By the way, looking at "git grep 'if (rte_'" suggests it is common.