> > I don't think rte_panic should be considered forbidden. Rather their > use should be flagged (as this patch does). However, the 'exit 1' > (which will return a failure for the automatic checkpatch script bot) > might end up problematic as maintainers might consider it a patch that > is not ready. > > I wouldn't object to this patch, but just think you might want to change > the print to something like: > > WARN: Are you sure you meant to use "$expression"? >
I can definitely change the warning text , but I think the whole point is actually to prevent future panic calls. If it were a recommendation, one can never converge with the attempt to get rid of them, as not throwing a panic is a lot harder. Thanks Arnon
