> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 16 August 2023 23.04 > > On Wed, Aug 16, 2023 at 10:55:51PM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 16 August 2023 21.19 > > > > > > Provide API for atomic operations in the rte namespace that may > > > optionally be configured to use C11 atomics with meson > > > option enable_stdatomics=true > > > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > > Reviewed-by: Morten Brørup <m...@smartsharesystems.com> > > > --- > > > > "#define RTE_ATOMIC(type) [...]" is missing in > lib/eal/include/rte_stdatomic.h, both with and without > RTE_ENABLE_STDATOMIC. > > > > I suggest you keep it together with "#define __rte_atomic [...]". > > this seems to be an error i made in patch submission, somehow i managed > to drop the changes i made from v2-v3 from the series i submitted i'm > confused how i managed to fat finger it.
Happens to me all the time - too often, if you look at my patch submission track record. ;-) > > i'll submit a new series with the correct changes to rte_stdatomic.h > > > > Please also add descriptions as comments to both (type-qualifier and - > specifier) in both locations. Your descriptions from the mailing list > discussion are fine. > > > > i'll do this in the v4 commit message Please put the descriptions about their usage in the code as documentation comments, not in the commit message. > > thanks
