On Thu, Aug 17, 2023 at 01:45:21PM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 16 August 2023 23.39 > > > > Provide API for atomic operations in the rte namespace that may > > optionally be configured to use C11 atomics with meson > > option enable_stdatomics=true > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > Reviewed-by: Morten Brørup <m...@smartsharesystems.com> > > --- > > Speed blindness during my review... I have now spotted a couple of copy-paste > typos: > > > +#define rte_atomic_compare_exchange_weak_explicit( \ > > + ptr, expected, desired, succ_memorder, fail_memorder) \ > > + atomic_compare_exchange_strong_explicit( \ > > atomic_compare_exchange_weak_explicit, not strong.
yikes, thanks for catching that cut & past error > > > + ptr, expected, desired, succ_memorder, fail_memorder) > > + > > [...] > > > +#define rte_atomic_flag_clear_explicit(ptr, memorder) \ > > + atomic_flag_clear(ptr, memorder) > > atomic_flag_clear_explicit(ptr, memorder), missing _explicit. yes, currently unused otherwise it would have failed to compie i'll correct this too. thank you for the careful review i look at the diffs over and over and still it's hard to spot subtle swaps/exchanges of things. >
