> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Friday, 11 August 2023 19.32
> 
> Adapt distributor for EAL optional atomics API changes
> 
> Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com>
> ---
>  lib/distributor/distributor_private.h    |  2 +-
>  lib/distributor/rte_distributor_single.c | 44 ++++++++++++++++---------------
> -
>  2 files changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/lib/distributor/distributor_private.h
> b/lib/distributor/distributor_private.h
> index 7101f63..ffbdae5 100644
> --- a/lib/distributor/distributor_private.h
> +++ b/lib/distributor/distributor_private.h
> @@ -52,7 +52,7 @@
>   * Only 64-bits of the memory is actually used though.
>   */
>  union rte_distributor_buffer_single {
> -     volatile int64_t bufptr64;
> +     volatile int64_t __rte_atomic bufptr64;

As mentioned in my review to the 2/6 patch, I think __rte_atomic should come 
before the type, like this:
> +     volatile __rte_atomic int64_t bufptr64;

>       char pad[RTE_CACHE_LINE_SIZE*3];
>  } __rte_cache_aligned;

The rest is simple search-replace; easy to review, so...

Reviewed-by: Morten Brørup <m...@smartsharesystems.com>

Reply via email to