> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Wednesday, 16 August 2023 23.39
> 
> Provide API for atomic operations in the rte namespace that may
> optionally be configured to use C11 atomics with meson
> option enable_stdatomics=true
> 
> Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com>
> Reviewed-by: Morten Brørup <m...@smartsharesystems.com>
> ---

Speed blindness during my review... I have now spotted a couple of copy-paste 
typos:

> +#define rte_atomic_compare_exchange_weak_explicit( \
> +         ptr, expected, desired, succ_memorder, fail_memorder) \
> +     atomic_compare_exchange_strong_explicit( \

atomic_compare_exchange_weak_explicit, not strong.

> +         ptr, expected, desired, succ_memorder, fail_memorder)
> +

[...]

> +#define rte_atomic_flag_clear_explicit(ptr, memorder) \
> +     atomic_flag_clear(ptr, memorder)

atomic_flag_clear_explicit(ptr, memorder), missing _explicit.

Reply via email to