Hi Thomas, Yes. The comments need to be fixed. I'll push a patch for that. Thanks for pointing out.
Thanks, Anoob > -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Tuesday, April 19, 2022 4:08 PM > To: Anoob Joseph <ano...@marvell.com> > Cc: Akhil Goyal <gak...@marvell.com>; dev@dpdk.org; > david.march...@redhat.com; hemant.agra...@nxp.com; > konstantin.anan...@intel.com; ciara.po...@intel.com; > ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; Nithin Kumar > Dabilpuram <ndabilpu...@marvell.com>; Vamsi Krishna Attunuru > <vattun...@marvell.com> > Subject: Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event > subtypes > > 19/04/2022 12:19, Anoob Joseph: > > Hi Thomas, Akhil, > > > > > Is there a reference explaining what exactly is a "soft packet expiry"? > > > > The SA lifetime/expiry is described in security library. > > https://urldefense.proofpoint.com/v2/url?u=https-3A__elixir.bootlin.co > > m_dpdk_latest_source_lib_security_rte-5Fsecurity.h- > 23L295&d=DwICAg&c=n > > KjWec2b6R0mOyPaz7xtfQ&r=jPfB8rwwviRSxyLWs2n6B- > WYLn1v9SyTMrT5EQqh2TU&m= > > > d9ONaYIdobFMxqt05JVZ3nT7rJib1rL35ax9X56teaPlvEGKpDNKMSCv1bYxhN8 > 1&s=jqz > > cuIk0XOpIidta-KGZ4zmUvmkhsnbe_VzT3QXAWe4&e= > > The comment you are referencing is using "soft" for all limits, even for > packets_hard_limit and bytes_hard_limit. > It seems these comments need to be fixed. >
