16/04/2022 21:25, Akhil Goyal: > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > /** Soft byte expiry of SA */ > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY, > + /** Soft packet expiry of SA */
Is there a reference explaining what exactly is a "soft packet expiry"? I think you should also mention what should be done in the event handler. > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > + /** Hard byte expiry of SA */ > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > + /** Hard packet expiry of SA */ > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, Same comment for the 3 events. > /** Max value of this enum */ > RTE_ETH_EVENT_IPSEC_MAX > }; What is the impact of this "MAX" value on ABI compatibility?