> > Time expiry means after x seconds SA will expire. > > Packet expiry means after x packets processing SA will expire. > > Byte expiry means after x bytes of packet processing SA will expire. > > I think you should use the syntax @ref packets_soft_limit > so it is clear where the event come from.
OK will update the comments. > > > > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > > > > + /** Hard byte expiry of SA */ > > > > + RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > > > > + /** Hard packet expiry of SA */ > > > > + RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, > > > > > > Same comment for the 3 events. > > > > > > > /** Max value of this enum */ > > > > RTE_ETH_EVENT_IPSEC_MAX > > > > }; > > > > > > What is the impact of this "MAX" value on ABI compatibility? > > > > I see no issues reported while running ABI check. > > There is no array being used inside library based on MAX. > > No need of array inside the library, the events are exposed to the app. > I'm surprised libabigail is OK with changing an enum value. > @Ray Can you please check if it is an issue to add more values in this enum?
