chaoyli commented on a change in pull request #563: Modify schema change to use
rowset
URL: https://github.com/apache/incubator-doris/pull/563#discussion_r250467548
##########
File path: be/src/olap/schema_change.h
##########
@@ -273,8 +279,8 @@ class SchemaChangeHandler {
OLAPStatus schema_version_convert(TabletSharedPtr ref_tablet,
TabletSharedPtr new_tablet,
- std::vector<SegmentGroup*>*
ref_segment_groups,
- std::vector<SegmentGroup*>*
new_segment_groups);
+ std::vector<RowsetSharedPtr>*
ref_rowsets,
Review comment:
new_rowsets may be corresponds to old_rowsets. So old_rowsets may be a
better name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
