chaoyli commented on a change in pull request #563: Modify schema change to use
rowset
URL: https://github.com/apache/incubator-doris/pull/563#discussion_r250472225
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -930,29 +874,22 @@ bool SchemaChangeWithSorting::process(ColumnData*
olap_data, SegmentGroup* new_s
RowBlock* ref_row_block = NULL;
bool need_create_empty_version = false;
OLAPStatus res = OLAP_SUCCESS;
- if (!olap_data->empty()) {
- res = olap_data->get_first_row_block(&ref_row_block);
+ if (rowset_reader->has_next()) {
Review comment:
has_next() is the same as empty() ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
